huyuanfeng2018 commented on code in PR #3074:
URL: https://github.com/apache/amoro/pull/3074#discussion_r1698463525
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/PaimonTableDescriptor.java:
##########
@@ -525,14 +525,19 @@ public List<TagOrBranchInfo>
getTableBranches(AmoroTable<?> amoroTable) {
@Override
public List<ConsumerInfo> getTableConsumerInfos(AmoroTable<?> amoroTable) {
FileStoreTable table = getTable(amoroTable);
+ FileStore<?> store = table.store();
ConsumerManager consumerManager = new ConsumerManager(table.fileIO(),
table.location());
List<ConsumerInfo> consumerInfos = new ArrayList<>();
try {
consumerManager
.consumers()
.forEach(
- (consumerId, nextSnapshot) ->
- consumerInfos.add(new ConsumerInfo(consumerId,
nextSnapshot)));
+ (consumerId, nextSnapshotId) -> {
+ Snapshot snapshot =
table.snapshotManager().snapshot(nextSnapshotId - 1);
Review Comment:
Will there be any exception when nextSnapshotId=1?
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/model/ConsumerInfo.java:
##########
@@ -48,4 +48,13 @@ public long getNextSnapshotId() {
public void setNextSnapshotId(long nextSnapshotId) {
this.nextSnapshotId = nextSnapshotId;
}
+
+ public AmoroSnapshotsOfTable getAmoroPreviousSnapshotsOfTable() {
Review Comment:
I don’t quite understand why the return the previous snapshot information .
Can you give some examples? Why is the current snapshot information not
displayed, but the previous one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
