huyuanfeng2018 commented on code in PR #3074:
URL: https://github.com/apache/amoro/pull/3074#discussion_r1699994910
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/PaimonTableDescriptor.java:
##########
@@ -525,14 +525,23 @@ public List<TagOrBranchInfo>
getTableBranches(AmoroTable<?> amoroTable) {
@Override
public List<ConsumerInfo> getTableConsumerInfos(AmoroTable<?> amoroTable) {
FileStoreTable table = getTable(amoroTable);
+ FileStore<?> store = table.store();
ConsumerManager consumerManager = new ConsumerManager(table.fileIO(),
table.location());
List<ConsumerInfo> consumerInfos = new ArrayList<>();
try {
consumerManager
.consumers()
.forEach(
- (consumerId, nextSnapshot) ->
- consumerInfos.add(new ConsumerInfo(consumerId,
nextSnapshot)));
+ (consumerId, nextSnapshotId) -> {
+ long currentSnapshotId = nextSnapshotId - 1;
Review Comment:
If can ensure that nextSnapshotId >0, i think don’t need this judgment.
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/model/ConsumerInfo.java:
##########
@@ -48,4 +48,12 @@ public long getNextSnapshotId() {
public void setNextSnapshotId(long nextSnapshotId) {
Review Comment:
We don’t seem to need this method. In my opinion, the member variables of
this class can be marked as final, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
