huyuanfeng2018 commented on code in PR #3074:
URL: https://github.com/apache/amoro/pull/3074#discussion_r1700042833
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/PaimonTableDescriptor.java:
##########
@@ -525,14 +525,23 @@ public List<TagOrBranchInfo>
getTableBranches(AmoroTable<?> amoroTable) {
@Override
public List<ConsumerInfo> getTableConsumerInfos(AmoroTable<?> amoroTable) {
FileStoreTable table = getTable(amoroTable);
+ FileStore<?> store = table.store();
ConsumerManager consumerManager = new ConsumerManager(table.fileIO(),
table.location());
List<ConsumerInfo> consumerInfos = new ArrayList<>();
try {
consumerManager
.consumers()
.forEach(
- (consumerId, nextSnapshot) ->
- consumerInfos.add(new ConsumerInfo(consumerId,
nextSnapshot)));
+ (consumerId, nextSnapshotId) -> {
+ long currentSnapshotId = nextSnapshotId - 1;
Review Comment:
If paimon itself can already determine that this is >1, do we not need to
judge anymore? If we add judgment, if there is an exception, the stack info
will be lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
