zhoujinsong commented on code in PR #3126:
URL: https://github.com/apache/amoro/pull/3126#discussion_r1726203456
##########
pom.xml:
##########
@@ -1324,5 +1324,21 @@
<lucene-dependency-scope>provided</lucene-dependency-scope>
</properties>
</profile>
+ <profile>
+ <id>fail-silent-on-no-git-dir</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>pl.project13.maven</groupId>
+ <artifactId>git-commit-id-plugin</artifactId>
+ <version>4.0.0</version>
+ <configuration>
Review Comment:
I am not sure if the profile plugin configuration will overwrite the default
configuration or merge into the default configuration.
As you just added the new configurations, it may seem to be they will be
merged into the default configuration, do we have any documentation about
profile behavior about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
