Re: [PR] [AMORO-3152] Make git-commit-plugin fail on no git dir configurable [amoro]

Thu, 22 Aug 2024 22:41:56 -0700 


klion26 commented on PR #3126:
URL: https://github.com/apache/amoro/pull/3126#issuecomment-2306332216

   After an offline discussion with @zhongqishang  we reached to consense that: 
add a new profile to enable the `no git dir` check, and make the check disabled 
default, because this has a better experience with new user which download the 
code with zip format.
    
   The code has been changed to the above change, please have a look when 
you're free thanks. @zhoujinsong @zhongqishang 
   
   normal build `mvn396 clean package  -pl 
'!amoro-mixed-format/amoro-mixed-format-trino' -DskipTests  
-Pskip-dashboard-build`
   
![WeChatWorkScreenshot_fee3c520-79b2-46ab-903f-55c62c380d30](https://github.com/user-attachments/assets/f672c328-2ad8-457b-b8c7-8035f11420f6)
   
   build after the check enabled `mvn396 clean package  -pl 
'!amoro-mixed-format/amoro-mixed-format-trino' -DskipTests  
-Pskip-dashboard-build -Pfail-on-no-git-dir`
   
![WeChatWorkScreenshot_9c9ce7ce-80a0-433c-b27d-311dc3782d68](https://github.com/user-attachments/assets/6e1c3dca-ac63-434d-aa40-22122324aeb5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to