klion26 commented on code in PR #3126:
URL: https://github.com/apache/amoro/pull/3126#discussion_r1726361944
##########
pom.xml:
##########
@@ -1324,5 +1324,21 @@
<lucene-dependency-scope>provided</lucene-dependency-scope>
</properties>
</profile>
+ <profile>
+ <id>fail-silent-on-no-git-dir</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>pl.project13.maven</groupId>
+ <artifactId>git-commit-id-plugin</artifactId>
+ <version>4.0.0</version>
+ <configuration>
Review Comment:
sorry for not attaching the result tested in my local env, has been attached
in the end now
the configuration in the profile will overwrite these in the build
configuration. the priority for the configuration is: `configuration in
profile(after enabled)` > `build configuration`. can ref the resource[1][2]
here.
the result after the profile enabled
the result for default(not enable the profile)
[1]
https://maven.apache.org/guides/introduction/introduction-to-profiles.html?spm=5176.28103460.0.0.6077572cRnkc6p#profile-inheritance
[2]
https://maven.apache.org/guides/introduction/introduction-to-the-pom.html#Project_Inheritance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
