avantgardnerio commented on code in PR #326:
URL: https://github.com/apache/arrow-site/pull/326#discussion_r1124474552
##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,31 @@ jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
+ container:
+ image: ubuntu:22.04 # Ubuntu 22.04 is the latest LTS version as of April
21, 2022: https://wiki.ubuntu.com/Releases
Review Comment:
Sadly I don't love any of the options here:
- Use ubuntu-latest (which has node 18) - not reproducible locally
- Use docker:22.04, but use the github action to install a more recent node
- not reproducible locally
- Add a deb package source and install via apt - fine in docker, not
recommended locally
- Use snap to install node - wonderful locally, but doesn't work in docker
- Install node version manager (nvm) in docker - maybe the best option?
- curl node and install the tarballs from the binary distribution
Sadly, this is one of those cases where what I would recommend in docker
(probably
[this](https://github.com/nodesource/distributions/blob/master/README.md#debinstall))
doesn't match what I would do locally (sudo snap install nodejs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
