kou commented on code in PR #326:
URL: https://github.com/apache/arrow-site/pull/326#discussion_r1128584928


##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,31 @@ jobs:
   deploy:
     name: Deploy
     runs-on: ubuntu-latest
+    container:
+      image: ubuntu:22.04 # Ubuntu 22.04 is the latest LTS version as of April 
21, 2022: https://wiki.ubuntu.com/Releases

Review Comment:
   Thanks for confirming this.
   
   How about the following steps to improve the current situation?
   
   1. We merge "no container" version 
https://github.com/mathworks/arrow-site/tree/GH-325-no-container because it's 
simpler than this version
   2. We create a `Dockerfile` based on `ubuntu:22.04` and use it in CI and 
https://github.com/apache/arrow-site#using-docker (This prevents breaking 
@alamb 's use case accidentally)
   3. We extract command lines used in 2. as a shell script and fine tune the 
shell script to work on host Ubuntu 22.04 too (@avantgardnerio 's use case)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to