kou commented on code in PR #326:
URL: https://github.com/apache/arrow-site/pull/326#discussion_r1129054155


##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,31 @@ jobs:
   deploy:
     name: Deploy
     runs-on: ubuntu-latest
+    container:
+      image: ubuntu:22.04 # Ubuntu 22.04 is the latest LTS version as of April 
21, 2022: https://wiki.ubuntu.com/Releases

Review Comment:
   My idea is that we just use `docker build && docker run` in GitHub Actions 
instead of `container:`.
   
   (More specifically, we will use `docker/build-push-action` instead of raw 
`docker build` and push a built image to `ghcr.io` to reuse the built image on 
local for https://github.com/apache/arrow-site#using-docker . 
https://github.com/groonga/groonga-delta/blob/main/.github/workflows/docker.yml 
is a bit old but may help you to understand my idea.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to