weiqingy commented on code in PR #2371:
URL: https://github.com/apache/auron/pull/2371#discussion_r3599694624
##########
auron-build.sh:
##########
@@ -165,6 +168,19 @@ while [[ $# -gt 0 ]]; do
exit 1
fi
;;
+ --platform)
+ if [[ -n "$2" && "$2" != -* ]]; then
+ DOCKER_PLATFORM="$2"
+ if [[ ! "$DOCKER_PLATFORM" =~
^[a-z0-9_.-]+/[a-z0-9_.-]+(/[a-z0-9_.-]+)?$ ]]; then
Review Comment:
Thanks for the PR update.
If this is a fix for Docker mode on ARM rather than a cross-build feature,
then `platform: ${AURON_DOCKER_PLATFORM:-linux/amd64}` looks like it would fix
that on its own — the `:-linux/amd64` default pins amd64 on an ARM host with no
flag involved. Is `--platform` carrying weight beyond that, or is amd64 the
only target these images can produce today?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
