zhaohehuhu commented on code in PR #2371:
URL: https://github.com/apache/auron/pull/2371#discussion_r3602079262
##########
auron-build.sh:
##########
@@ -165,6 +168,19 @@ while [[ $# -gt 0 ]]; do
exit 1
fi
;;
+ --platform)
+ if [[ -n "$2" && "$2" != -* ]]; then
+ DOCKER_PLATFORM="$2"
+ if [[ ! "$DOCKER_PLATFORM" =~
^[a-z0-9_.-]+/[a-z0-9_.-]+(/[a-z0-9_.-]+)?$ ]]; then
Review Comment:
We can probably remove --platform for now if there is no plan to support ARM
builds. @weiqingy
##########
auron-build.sh:
##########
@@ -165,6 +168,19 @@ while [[ $# -gt 0 ]]; do
exit 1
fi
;;
+ --platform)
+ if [[ -n "$2" && "$2" != -* ]]; then
+ DOCKER_PLATFORM="$2"
+ if [[ ! "$DOCKER_PLATFORM" =~
^[a-z0-9_.-]+/[a-z0-9_.-]+(/[a-z0-9_.-]+)?$ ]]; then
Review Comment:
We can probably remove ``--platform`` for now if there is no plan to support
ARM builds. @weiqingy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
