Perdjesk commented on code in PR #778:
URL:
https://github.com/apache/incubator-baremaps/pull/778#discussion_r1322901439
##########
baremaps-cli/pom.xml:
##########
@@ -157,27 +190,12 @@
<version>2.2.0</version>
<configuration>
<force>true</force>
- <thirdPartyFilename>THIRD-PARTY</thirdPartyFilename>
- <!-- Template to group by license with handling of multi licensing
-->
- <fileTemplate>${basedir}/licenseBundledDeps.ftl</fileTemplate>
- <!-- Only bundled bits matters
https://infra.apache.org/licensing-howto.html#bundled-vs-non-bundled -->
+ <outputDirectory>${thirdparty.directory}</outputDirectory>
+ <thirdPartyFilename>${thirdparty.filename}</thirdPartyFilename>
<excludedScopes>test,provided</excludedScopes>
- <!-- If true enforces excluding transitive dependencies of the
excluded artifacts in the reactor;
- otherwise only artifacts that match exclude filters are excluded.
- It excludes all transitives dependencies of excludedScopes
dependencies. -->
<excludeTransitiveDependencies>true</excludeTransitiveDependencies>
Review Comment:
Doing some testing in more depth regards of this configuration, I figured it
is wrong to have it to true.
The case that triggered enabling this is in fact correct. It can happens
that a direct dependency with scope test has a dependency that is included in
the jar/binary release.
`org.apiguardian:apiguardian-api` is a dependency of
`org.junit.jupiter:junit-jupiter-api` and `org.apache.calcite:calcite-core`.
Given that calcite is included with scope compile, it is the expected to see:
```
+- org.junit.jupiter:junit-jupiter-api:jar:5.7.1:test
+- org.apiguardian:apiguardian-api:jar:1.1.0:compile
+- org.opentest4j:opentest4j:jar:1.2.0:test
\- org.junit.platform:junit-platform-commons:jar:1.7.1:test
```
And `org.apiguardian:apiguardian-api` must be in the LICENSE file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
