bchapuis commented on code in PR #778:
URL:
https://github.com/apache/incubator-baremaps/pull/778#discussion_r1322904785
##########
baremaps-cli/pom.xml:
##########
@@ -157,27 +190,12 @@
<version>2.2.0</version>
<configuration>
<force>true</force>
- <thirdPartyFilename>THIRD-PARTY</thirdPartyFilename>
- <!-- Template to group by license with handling of multi licensing
-->
- <fileTemplate>${basedir}/licenseBundledDeps.ftl</fileTemplate>
- <!-- Only bundled bits matters
https://infra.apache.org/licensing-howto.html#bundled-vs-non-bundled -->
+ <outputDirectory>${thirdparty.directory}</outputDirectory>
+ <thirdPartyFilename>${thirdparty.filename}</thirdPartyFilename>
<excludedScopes>test,provided</excludedScopes>
- <!-- If true enforces excluding transitive dependencies of the
excluded artifacts in the reactor;
- otherwise only artifacts that match exclude filters are excluded.
- It excludes all transitives dependencies of excludedScopes
dependencies. -->
<excludeTransitiveDependencies>true</excludeTransitiveDependencies>
Review Comment:
Should I remove this line?
I will try to merge this tonight and to publish a second release candidate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
