Perdjesk commented on code in PR #778:
URL:
https://github.com/apache/incubator-baremaps/pull/778#discussion_r1322931004
##########
baremaps-cli/pom.xml:
##########
@@ -157,27 +190,12 @@
<version>2.2.0</version>
<configuration>
<force>true</force>
- <thirdPartyFilename>THIRD-PARTY</thirdPartyFilename>
- <!-- Template to group by license with handling of multi licensing
-->
- <fileTemplate>${basedir}/licenseBundledDeps.ftl</fileTemplate>
- <!-- Only bundled bits matters
https://infra.apache.org/licensing-howto.html#bundled-vs-non-bundled -->
+ <outputDirectory>${thirdparty.directory}</outputDirectory>
+ <thirdPartyFilename>${thirdparty.filename}</thirdPartyFilename>
<excludedScopes>test,provided</excludedScopes>
- <!-- If true enforces excluding transitive dependencies of the
excluded artifacts in the reactor;
- otherwise only artifacts that match exclude filters are excluded.
- It excludes all transitives dependencies of excludedScopes
dependencies. -->
<excludeTransitiveDependencies>true</excludeTransitiveDependencies>
Review Comment:
Removing this incorrect configuration allow then to properly handle the
circular dependency to baremaps components in the LICENSE:
```
<excludedGroups>^org\.apache\.baremaps</excludedGroups>
```
To remove:
```
org.apache.baremaps--baremaps-core--0.7.2-SNAPSHOT=Apache License 2.0
org.apache.baremaps--baremaps-ogcapi--0.7.2-SNAPSHOT=Apache License 2.0
org.apache.baremaps--baremaps-server--0.7.2-SNAPSHOT=Apache License 2.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
