[
https://issues.apache.org/jira/browse/BEAM-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786421#comment-15786421
]
ASF GitHub Bot commented on BEAM-370:
-------------------------------------
GitHub user bjchambers opened a pull request:
https://github.com/apache/beam/pull/1718
[BEAM-370] Remove more `.named()` methods
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [*] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [*(] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [*] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bjchambers/beam combine-named
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1718.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1718
----
commit 1c83b6d3830a6073579e63f499383403255067c7
Author: bchambers <[email protected]>
Date: 2016-12-29T21:01:24Z
Move name utilities from StringUtils to NameUtils
commit 698a5239f9bccc5505a52d8675010446e0fe4cde
Author: bchambers <[email protected]>
Date: 2016-12-29T21:30:53Z
squash! Add more exhaustive tests for NameUtils
commit ab5dd68cfbbef07f6cfae83ef5fd9f8429092a12
Author: bchambers <[email protected]>
Date: 2016-12-29T21:42:30Z
squash! Remove unused name fields from ParDo constructors
commit 45547612c8200ddc4ea275aca74a6902d3f8512e
Author: bchambers <[email protected]>
Date: 2016-12-29T21:10:13Z
squash! Remove .named from Combine
Introduces a NameOverride interface that allows some classes to define
custom behavior for getting the name. This is necessary for
parameterized CombineFns to expose details about their parameter values.
----
> Remove the .named() methods from PTransforms and sub-classes
> ------------------------------------------------------------
>
> Key: BEAM-370
> URL: https://issues.apache.org/jira/browse/BEAM-370
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Ben Chambers
> Assignee: Ben Chambers
> Priority: Minor
> Labels: backward-incompatible
>
> 1. Update examples/tests/etc. to use named application instead of `.named()`
> 2. Remove the `.named()` methods from composite PTransforms
> 3. Where appropriate, use the the PTransform constructor which takes a string
> to use as the default name.
> See further discussion in the related thread
> (http://mail-archives.apache.org/mod_mbox/incubator-beam-dev/201606.mbox/%3ccan-7fgzuz1f_szzd2orfyd2pk2_prymhgwjepjpefp01h7s...@mail.gmail.com%3E).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
