[ 
https://issues.apache.org/jira/browse/BEAM-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796246#comment-15796246
 ] 

ASF GitHub Bot commented on BEAM-370:
-------------------------------------

GitHub user bjchambers opened a pull request:

    https://github.com/apache/beam/pull/1730

    [BEAM-370] Remove last mention of PTransform#named

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [*] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [*] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [*] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/beam ptransform-named

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1730
    
----
commit 175bcbc987cd56370433118f93d3559bdd09b103
Author: bchambers <[email protected]>
Date:   2017-01-03T21:30:45Z

    [BEAM-370] Remove last mention of PTransform#named

----


> Remove the .named() methods from PTransforms and sub-classes
> ------------------------------------------------------------
>
>                 Key: BEAM-370
>                 URL: https://issues.apache.org/jira/browse/BEAM-370
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Ben Chambers
>            Assignee: Ben Chambers
>            Priority: Minor
>              Labels: backward-incompatible
>
> 1. Update examples/tests/etc. to use named application instead of `.named()`
> 2. Remove the `.named()` methods from composite PTransforms
> 3. Where appropriate, use the the PTransform constructor which takes a string 
> to use as the default name.
> See further discussion in the related thread 
> (http://mail-archives.apache.org/mod_mbox/incubator-beam-dev/201606.mbox/%3ccan-7fgzuz1f_szzd2orfyd2pk2_prymhgwjepjpefp01h7s...@mail.gmail.com%3E).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to