[jira] (BEAM-1346) Drop Late Data in ReduceFnRunner

[Kenneth Knowles (JIRA)]

Title: Message Title

Kenneth Knowles commented on BEAM-1346   Re: Drop Late Data in ReduceFnRunner Yikes, that is a troubling lack of test coverage that it could go away without being caught. I probably reviewed it Previously, because GroupAlsoByWindowViaWindowSets followed the same code path as a user-defined DoFn, the way we would distinguish it was checking for ReduceFnExecutor (technically, I think ReduceFnExecutor only applied if the GABW took KeyedWorkItem as input, which was always true for streaming runners, kind of a random collection of dependencies). The right way to fix this IMO is for the flink WindowDoFnOperator to explicitly create a lateDataDroppingRunner() since that code already knows it is using GABW. Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)