[
https://issues.apache.org/jira/browse/BEAM-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847109#comment-15847109
]
Aljoscha Krettek commented on BEAM-1346:
----------------------------------------
[~kenn], yes exactly, that's how I was able to home in on those two commits.
The changes are still good, we just need another place in to code to do the
late-data dropping.
> Drop Late Data in ReduceFnRunner
> --------------------------------
>
> Key: BEAM-1346
> URL: https://issues.apache.org/jira/browse/BEAM-1346
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Affects Versions: 0.5.0
> Reporter: Aljoscha Krettek
>
> I think these two commits recently broke late-data dropping for the Flink
> Runner (and maybe for other runners as well):
> - https://github.com/apache/beam/commit/2b26ec8
> - https://github.com/apache/beam/commit/8989473
> It boils down to the {{LateDataDroppingDoFnRunner}} not being used anymore
> because {{DoFnRunners.lateDataDroppingRunner()}} is not called anymore when a
> {{DoFn}} is a {{ReduceFnExecutor}} (because that interface was removed).
> Maybe we should think about dropping late data in another place, my
> suggestion is {{ReduceFnRunner}} but that's open for discussion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
