[
https://issues.apache.org/jira/browse/BEAM-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847293#comment-15847293
]
Kenneth Knowles commented on BEAM-1346:
---------------------------------------
[~aljoscha] that is a very interesting point and I think I agree with you,
though I need to ponder it a little more.
For context, at some point I switched late data dropping from {{(WM -
timestamp) > allowedLateness}} to the simpler-to-understand and seemingly
better-behaved {{(WM - EOW) > allowedLateness}} (big caveat that it doesn't
work in global window, but you always have to stream with a trigger and
discarding mode there to avoid leaks). In the first situation, the sort of data
you are talking about was always dropped anyhow. When I switched it, I did not
make any special consideration for tiny to-be-merged "proto"-windows. So they
are still dropped somewhat like the original design, when {{(WM - gap duration
- timestamp) > allowedLateness}}. I think that question fits this ticket, but
doesn't relate to the release blocking question since it has been like this
since before Beam I think.
> Drop Late Data in ReduceFnRunner
> --------------------------------
>
> Key: BEAM-1346
> URL: https://issues.apache.org/jira/browse/BEAM-1346
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Affects Versions: 0.5.0
> Reporter: Aljoscha Krettek
>
> I think these two commits recently broke late-data dropping for the Flink
> Runner (and maybe for other runners as well):
> - https://github.com/apache/beam/commit/2b26ec8
> - https://github.com/apache/beam/commit/8989473
> It boils down to the {{LateDataDroppingDoFnRunner}} not being used anymore
> because {{DoFnRunners.lateDataDroppingRunner()}} is not called anymore when a
> {{DoFn}} is a {{ReduceFnExecutor}} (because that interface was removed).
> Maybe we should think about dropping late data in another place, my
> suggestion is {{ReduceFnRunner}} but that's open for discussion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
