[
https://issues.apache.org/jira/browse/BEAM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866785#comment-15866785
]
ASF GitHub Bot commented on BEAM-646:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2006
[BEAM-646] Get the #apply out of the DirectRunner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Use the Graph Surgery API in the DirectRunner.
The Forwarding View is currently required to ensure that the `WriteView`
transform
is marked as the producer of the View proper. It is then replaced by the
original view,
so the Pipeline writes the view to the correct location.
I'm going to revisit the producer-marking code soon, but this is safe to
review.
I also missed invariant maintenance within TransformHierarchy within #1998,
so that's added here as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam surgery_ish
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2006.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2006
----
commit 46543d75a92b8c6c19b55581ec8253ffd76f4058
Author: Thomas Groh <[email protected]>
Date: 2017-02-09T19:37:33Z
Return a Forwarding View in View Overrides
This ensures that replacing an output will not fail to mark the
overridden view as produced by the replacement transform.
commit e950ba71d7cc6910c6be7dd39576bca3c96287de
Author: Thomas Groh <[email protected]>
Date: 2017-02-14T21:56:07Z
Add the replacement input to Unexpanded Inputs
commit a8bf815ea4f0ff3bc9701936cd1547d222eafebc
Author: Thomas Groh <[email protected]>
Date: 2017-02-09T19:45:06Z
Use Graph Surgery in the DirectRunner
Remove DirectRunner#apply(). This migrates the DirectRunner to work on a
runner-agnostic graph.
----
> Get runners out of the apply()
> ------------------------------
>
> Key: BEAM-646
> URL: https://issues.apache.org/jira/browse/BEAM-646
> Project: Beam
> Issue Type: Improvement
> Components: beam-model-runner-api, sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Thomas Groh
>
> Right now, the runner intercepts calls to apply() and replaces transforms as
> we go. This means that there is no "original" user graph. For portability and
> misc architectural benefits, we would like to build the original graph first,
> and have the runner override later.
> Some runners already work in this manner, but we could integrate it more
> smoothly, with more validation, via some handy APIs on e.g. the Pipeline
> object.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
