[
https://issues.apache.org/jira/browse/BEAM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879423#comment-15879423
]
ASF GitHub Bot commented on BEAM-646:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2078
[BEAM-646] Specialize ISM View Translations
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
These translations have a different coder than the original view, which
is required on the worker side to be transmitted as part of the
Singleton Output, and are generally not compatible with the replacements
performed during Pipeline Surgery. Specializing this translation allows
the updated coders to be set on the output view based on the overriding
transform, rather than the output node, as the view needs to remain
consistent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam ism_coder_specialized_override
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2078.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2078
----
commit 519e8f2495f9463119f190a29e53c8398cb7ec7e
Author: Thomas Groh <[email protected]>
Date: 2017-02-22T22:59:08Z
Specialize ISM View Translations
These translations have a different coder than the original view, which
is required on the worker side to be transmitted as part of the
Singleton Output, and are generally not compatible with the replacements
performed during Pipeline Surgery. Specializing this translation allows
the updated coders to be set on the output view based on the overriding
transform, rather than the output node, as the view needs to remain
consistent.
----
> Get runners out of the apply()
> ------------------------------
>
> Key: BEAM-646
> URL: https://issues.apache.org/jira/browse/BEAM-646
> Project: Beam
> Issue Type: Improvement
> Components: beam-model-runner-api, sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Thomas Groh
> Labels: backwards-incompatible
>
> Right now, the runner intercepts calls to apply() and replaces transforms as
> we go. This means that there is no "original" user graph. For portability and
> misc architectural benefits, we would like to build the original graph first,
> and have the runner override later.
> Some runners already work in this manner, but we could integrate it more
> smoothly, with more validation, via some handy APIs on e.g. the Pipeline
> object.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
