[ 
https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934683#comment-15934683
 ] 

Aviem Zur commented on BEAM-775:
--------------------------------

Awesome to see we are moving forward with the removal of aggregators.

However, I see that the PRs related to this ticket replace aggregators with 
metrics.

Since metrics are not supported yet in all runners, how is this going to work?

My chief concern is the success and failure counters in {{PAssert}} since these 
verify that {{RunnableOnService}} tests do in fact test what they are supposed 
to (There have been and are instances in which the runners did not perform the 
assertion but the test passed, and this masked an actual bug in the runner).

> Remove Aggregators from the Java SDK
> ------------------------------------
>
>                 Key: BEAM-775
>                 URL: https://issues.apache.org/jira/browse/BEAM-775
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Ben Chambers
>            Assignee: Ben Chambers
>              Labels: backward-incompatible
>             Fix For: First stable release
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to