[ 
https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935735#comment-15935735
 ] 

Ben Chambers commented on BEAM-775:
-----------------------------------

(Note BEAM-1148 originally tracked porting PAssert off of Aggregators)

I don't believe Metrics will work for this. Specifically since most runners 
don't track values across committed bundles and instead only support attempted 
metrics, they may over or undercount.

Depending on a flaky value from Metrics for testing seems like it would be a 
step backwards in terms of flakiness of tests.

It may be useful to think about how to move PAsserts off aggregators/metrics 
towards something more reliable -- perhaps a deterministic completion sink that 
just writes the name of the assert that has been executed.

> Remove Aggregators from the Java SDK
> ------------------------------------
>
>                 Key: BEAM-775
>                 URL: https://issues.apache.org/jira/browse/BEAM-775
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Ben Chambers
>            Assignee: Pablo Estrada
>              Labels: backward-incompatible
>             Fix For: First stable release
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to