[
https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935141#comment-15935141
]
Kenneth Knowles commented on BEAM-775:
--------------------------------------
I think it used to be that aggregators checked that the test actually
remembered to run a {{PAssert}} transform. Some of this is handled by
{{TestPipeline}} now. But the new logic there means that a failure is a major
bug in the runner or a bug in {{PAssert}}. I don't think it is really possible
for a runner to have basic support for primitives and for an assert to fail to
run, unless the whole pipeline fails, too, which is fine for failing the test.
Am I missing some situation?
There are other places, like {{ReduceFnRunner}} where we need metrics or we
lose the count of dropped elements.
> Remove Aggregators from the Java SDK
> ------------------------------------
>
> Key: BEAM-775
> URL: https://issues.apache.org/jira/browse/BEAM-775
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Ben Chambers
> Assignee: Pablo Estrada
> Labels: backward-incompatible
> Fix For: First stable release
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
