[ 
https://issues.apache.org/jira/browse/BEAM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219846#comment-16219846
 ] 

ASF GitHub Bot commented on BEAM-1872:
--------------------------------------

GitHub user udim opened a pull request:

    https://github.com/apache/beam/pull/4040

    [BEAM-1872] Add IdentityWindowFn for use in Reshuffle

    BEAM-1872 IdentityWindowFn is intended for internal use in a future
    implementation of Reshuffle.
    
    Add and pass current window to WindowFn.AssignContext, for
    IdentityWindowFn implementation.
    
    Add WindowedValueMatcher in testing/util.py, for use in IdentityWindowFn
    unit tests.
    
    ----
    
    Hi @robertwb. Can you please take a look?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/udim/beam reshuffle_py

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4040
    
----
commit cb5bd6dbba492221e74889c70a503c2544a828c5
Author: Udi Meiri <[email protected]>
Date:   2017-10-25T22:45:39Z

    Add IdentityWindowFn.
    
    BEAM-1872 IdentityWindowFn is intended for internal use in a future
    implementation of Reshuffle.
    
    Add and pass current window to WindowFn.AssignContext, for
    IdentityWindowFn implementation.
    
    Add WindowedValueMatcher in testing/util.py, for use in IdentityWindowFn
    unit tests.

----


> implement Reshuffle transform in python, make it experimental in Java
> ---------------------------------------------------------------------
>
>                 Key: BEAM-1872
>                 URL: https://issues.apache.org/jira/browse/BEAM-1872
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core, sdk-py-core
>            Reporter: Ahmet Altay
>              Labels: sdk-consistency
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to