[
https://issues.apache.org/jira/browse/BEAM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269680#comment-16269680
]
ASF GitHub Bot commented on BEAM-1872:
--------------------------------------
udim commented on a change in pull request #4040: [BEAM-1872] Add
IdentityWindowFn for use in Reshuffle
URL: https://github.com/apache/beam/pull/4040#discussion_r153653663
##########
File path: sdks/python/apache_beam/testing/util.py
##########
@@ -46,6 +56,26 @@ class BeamAssertException(Exception):
pass
+# Used for reifying timestamps and windows for assert_that matchers.
Review comment:
<!--thread_id:cc_151221908_t;
commit:4fa4caa4b4991fe994ce3938f37be975421c6761; resolved:1-->
<!--section:context-quote-->
> **robertwb** wrote:
> Ideally one should be able to use any callable, e.g. hamcrest matchers,
rather than have to implement a windowed variant of each. I misspoke about
having a windowed_equals_to, we should have a `assert_that_windowed(pcoll,
equal_to([WindowedValue(...), ...]))`, or `assert_that(pcoll,
equal_to([WindowedValue(...), ...], reify_windows=True)`.
<!--section:body-->
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> implement Reshuffle transform in python, make it experimental in Java
> ---------------------------------------------------------------------
>
> Key: BEAM-1872
> URL: https://issues.apache.org/jira/browse/BEAM-1872
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Udi Meiri
> Labels: sdk-consistency
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
