[
https://issues.apache.org/jira/browse/BEAM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269682#comment-16269682
]
ASF GitHub Bot commented on BEAM-1872:
--------------------------------------
udim commented on a change in pull request #4040: [BEAM-1872] Add
IdentityWindowFn for use in Reshuffle
URL: https://github.com/apache/beam/pull/4040#discussion_r153653664
##########
File path: sdks/python/apache_beam/transforms/util.py
##########
@@ -423,3 +431,115 @@ def expand(self, pcoll):
self._batch_size_estimator))
else:
return pcoll |
ParDo(_WindowAwareBatchingDoFn(self._batch_size_estimator))
+
+
+class IdentityWindowFn(NonMergingWindowFn):
+ """Windowing function that preserves existing windows.
+
+ To be used internally with the Reshuffle transform.
+ Will raise an exception when used after DoFns that return TimestampedValue
+ elements.
+ """
+
+ def __init__(self, coder):
+ """Create a new WindowFn with compatible coder.
+ To be applied to PCollections with windows that are compatible with the
+ given coder.
+
+ Arguments:
+ coder: coders.Coder object to be used on windows.
+ """
+ super(IdentityWindowFn, self).__init__()
+ if coder is None:
+ raise ValueError('coder should not be None')
+ self._coder = coder
Review comment:
<!--thread_id:cc_151217099_t;
commit:4fa4caa4b4991fe994ce3938f37be975421c6761; resolved:1-->
<!--section:context-quote-->
> **robertwb** wrote:
> Rename this window_coder?
<!--section:body-->
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> implement Reshuffle transform in python, make it experimental in Java
> ---------------------------------------------------------------------
>
> Key: BEAM-1872
> URL: https://issues.apache.org/jira/browse/BEAM-1872
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Udi Meiri
> Labels: sdk-consistency
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
