[ 
https://issues.apache.org/jira/browse/BEAM-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327880#comment-16327880
 ] 

ASF GitHub Bot commented on BEAM-3250:
--------------------------------------

bsidhom opened a new pull request #4418: [BEAM-3250] Migrate Flink and Spark 
ValidatesRunner to Gradle
URL: https://github.com/apache/beam/pull/4418
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
    - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
    - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   
   Note that Gradle does not support scanning arbitrary jars/dependencies for 
test classes. For this reason, this change inverts structure of the 
validates-runner tests, moving them into `sdks/java/core` rather than the 
runner modules themselves. This does not create a cyclic dependency because 
dependencies are analyzed by module/configuration rather than by module.
   
   On my machine, the Flink validates-runner tests take about 20 minutes to run 
on maven and about 5 minutes to run with Gradle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -----------------------------------------------------
>
>                 Key: BEAM-3250
>                 URL: https://issues.apache.org/jira/browse/BEAM-3250
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system, testing
>            Reporter: Luke Cwik
>            Assignee: Kenneth Knowles
>            Priority: Major
>
> Update these targets to execute ValidatesRunner tests: 
> https://github.com/apache/beam/search?l=Groovy&q=ValidatesRunner&type=&utf8=%E2%9C%93



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to