[ https://issues.apache.org/jira/browse/BEAM-3942?focusedWorklogId=88678&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88678 ]
ASF GitHub Bot logged work on BEAM-3942: ---------------------------------------- Author: ASF GitHub Bot Created on: 07/Apr/18 02:15 Start Date: 07/Apr/18 02:15 Worklog Time Spent: 10m Work Description: chamikaramj commented on a change in pull request #5003: [BEAM-3942] Update performance testing framework to use Gradle URL: https://github.com/apache/beam/pull/5003#discussion_r179905431 ########## File path: build_rules.gradle ########## @@ -593,6 +593,118 @@ ext.applyJavaNature = { } } +// Reads and contains all necessary performance test parameters +class JavaPerformanceTestConfiguration { + String pkbLocation = System.getProperty('pkbLocation') + + String logLevel = System.getProperty('logLevel', 'INFO') + String gradleBinary = System.getProperty('gradleBinary', './gradlew') + String isOfficial = System.getProperty('official', 'true') + String benchmarks = System.getProperty('benchmarks', 'beam_integration_benchmark') + + String beamPrebuilt = System.getProperty('beamPrebuilt', 'true') + String beamSdk = System.getProperty('beamSdk', 'java') + + String timeout = System.getProperty('itTimeout', '1200') + + String kubeconfig = System.getProperty('kubeconfig', System.getProperty('user.home') + '/.kube/config') + String kubectl = System.getProperty('kubectl', 'kubectl') + + // PerfKit will have trouble reading 'null' path. It expects empty string if no scripts are expected. Review comment: Is this something we can fix at PerfKit side (and not specify empty strings here) ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 88678) Time Spent: 2.5h (was: 2h 20m) > Update performance testing framework to use Gradle. > --------------------------------------------------- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing > Reporter: Chamikara Jayalath > Assignee: Ćukasz Gajowy > Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)