ASF GitHub Bot logged work on BEAM-3942:

                Author: ASF GitHub Bot
            Created on: 10/Apr/18 14:40
            Start Date: 10/Apr/18 14:40
    Worklog Time Spent: 10m 
      Work Description: lgajowy commented on a change in pull request #5003: 
[BEAM-3942] Update performance testing framework to use Gradle
URL: https://github.com/apache/beam/pull/5003#discussion_r180446301

 File path: build_rules.gradle
 @@ -593,6 +593,118 @@ ext.applyJavaNature = {
+// Reads and contains all necessary performance test parameters
+class JavaPerformanceTestConfiguration {
+  String pkbLocation = System.getProperty('pkbLocation')
+  String logLevel = System.getProperty('logLevel', 'INFO')
+  String gradleBinary = System.getProperty('gradleBinary', './gradlew')
+  String isOfficial = System.getProperty('official', 'true')
 Review comment:
   No we shouldn't - this would mark benchmark results being marked as official 
which even in Perfkit is defaulted to false. The task is for running them from 
local machines so those are definitely not official test results.  It should be 
false then - my bad.
   I added a comment describing this in more detail in next commit

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 89413)
    Time Spent: 3.5h  (was: 3h 20m)

> Update performance testing framework to use Gradle.
> ---------------------------------------------------
>                 Key: BEAM-3942
>                 URL: https://issues.apache.org/jira/browse/BEAM-3942
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Chamikara Jayalath
>            Assignee: Ɓukasz Gajowy
>            Priority: Major
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
> This requires performing updates to PerfKitBenchmarker and Beam so that we 
> can execute performance tests using Gradle.

This message was sent by Atlassian JIRA

Reply via email to