ASF GitHub Bot logged work on BEAM-3942:

                Author: ASF GitHub Bot
            Created on: 10/Apr/18 14:40
            Start Date: 10/Apr/18 14:40
    Worklog Time Spent: 10m 
      Work Description: lgajowy commented on a change in pull request #5003: 
[BEAM-3942] Update performance testing framework to use Gradle
URL: https://github.com/apache/beam/pull/5003#discussion_r180446379

 File path: sdks/java/io/cassandra/build.gradle
 @@ -18,6 +18,7 @@
 apply from: project(":").file("build_rules.gradle")
 applyJavaNature(artifactId: "beam-sdks-java-io-cassandra")
 Review comment:
   This adds `integrationTest` task to cassandra io's build.gradle file. It 
works the same way as `applyJavaNature()` but adds integration testing related 
things. The way it is done now requires developers explicitly "append" the 
tasks to every module that needs ITs by adding `enableJavaPerformanceTesting()` 
in build.gradle file.
   An alternative would be to include this task (along with 
`packageIntegrationTests` ) to `applyJavaNature()` closure. This would add the 
tasks (`integrationTests`, `packageIntegrationTest` to every module that uses 
`applyJavaNature()`, so it's more implicit. 
   What do you think? Which option do you like better?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 89415)
    Time Spent: 3h 50m  (was: 3h 40m)

> Update performance testing framework to use Gradle.
> ---------------------------------------------------
>                 Key: BEAM-3942
>                 URL: https://issues.apache.org/jira/browse/BEAM-3942
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Chamikara Jayalath
>            Assignee: Ɓukasz Gajowy
>            Priority: Major
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
> This requires performing updates to PerfKitBenchmarker and Beam so that we 
> can execute performance tests using Gradle.

This message was sent by Atlassian JIRA

Reply via email to