[ 
https://issues.apache.org/jira/browse/BEAM-2990?focusedWorklogId=90244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90244
 ]

ASF GitHub Bot logged work on BEAM-2990:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/18 00:56
            Start Date: 12/Apr/18 00:56
    Worklog Time Spent: 10m 
      Work Description: XuMingmin commented on a change in pull request #5079: 
[BEAM-2990] support MAP in SQL schema
URL: https://github.com/apache/beam/pull/5079#discussion_r180939363
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
 ##########
 @@ -242,6 +247,10 @@ public FieldType type() {
     public abstract TypeName getTypeName();
     // For container types (e.g. ARRAY), returns the type of the contained 
element.
     @Nullable public abstract FieldType getComponentType();
+    // For MAP type, returns the type of the key element.
+    @Nullable public abstract FieldType getComponentKeyType();
+    // For MAP type, returns the type of the value element.
+    @Nullable public abstract FieldType getComponentValueType();
 
 Review comment:
   +1, will change to key as primitive, and value can be primitive/array/map/row

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 90244)
    Time Spent: 3h  (was: 2h 50m)

> support data type MAP
> ---------------------
>
>                 Key: BEAM-2990
>                 URL: https://issues.apache.org/jira/browse/BEAM-2990
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>            Priority: Major
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> support Non-scalar types:
> MAP   Collection of keys mapped to values
> ARRAY         Ordered, contiguous collection that may contain duplicates



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to