[ https://issues.apache.org/jira/browse/BEAM-2990?focusedWorklogId=91103&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91103 ]
ASF GitHub Bot logged work on BEAM-2990: ---------------------------------------- Author: ASF GitHub Bot Created on: 14/Apr/18 23:37 Start Date: 14/Apr/18 23:37 Worklog Time Spent: 10m Work Description: reuvenlax commented on a change in pull request #5079: [BEAM-2990] support MAP in SQL schema URL: https://github.com/apache/beam/pull/5079#discussion_r181566422 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java ########## @@ -252,7 +264,9 @@ public FieldType type() { @AutoValue.Builder abstract static class Builder { abstract Builder setTypeName(TypeName typeName); - abstract Builder setComponentType(@Nullable FieldType componentType); + abstract Builder setCollectionType(@Nullable FieldType collectionType); Review comment: <!--new_thread; commit:4ec9e60e06584a642db426cf6cf5ccd57cb62337; resolved:0--> nitpick here: collectionType reads weird to me, as it seems like it's the type of collection (e.g. array, list, tree, etc.) instead of the type of the component elements of the collection. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 91103) Time Spent: 4h 50m (was: 4h 40m) > support data type MAP > --------------------- > > Key: BEAM-2990 > URL: https://issues.apache.org/jira/browse/BEAM-2990 > Project: Beam > Issue Type: New Feature > Components: dsl-sql > Reporter: Xu Mingmin > Assignee: Xu Mingmin > Priority: Major > Time Spent: 4h 50m > Remaining Estimate: 0h > > support Non-scalar types: > MAP Collection of keys mapped to values > ARRAY Ordered, contiguous collection that may contain duplicates -- This message was sent by Atlassian JIRA (v7.6.3#76005)