[ 
https://issues.apache.org/jira/browse/BEAM-2990?focusedWorklogId=90755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90755
 ]

ASF GitHub Bot logged work on BEAM-2990:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Apr/18 09:45
            Start Date: 13/Apr/18 09:45
    Worklog Time Spent: 10m 
      Work Description: reuvenlax commented on a change in pull request #5079: 
[BEAM-2990] support MAP in SQL schema
URL: https://github.com/apache/beam/pull/5079#discussion_r181337451
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
 ##########
 @@ -208,6 +209,7 @@ public int hashCode() {
     public static final Set<TypeName> STRING_TYPES = ImmutableSet.of(STRING);
     public static final Set<TypeName> DATE_TYPES = ImmutableSet.of(DATETIME);
     public static final Set<TypeName> CONTAINER_TYPES = ImmutableSet.of(ARRAY);
+    public static final Set<TypeName> MAP_TYPES = ImmutableSet.of(MAP);
 
 Review comment:
   <!--thread_id:cc_180705569_t; 
commit:7bf9d2048e8d568ee9280629db391775cc490358; resolved:0-->
   <!--section:context-quote-->
   > **XuMingmin** wrote:
   > would separate here, CONTAINER should be ARRAY/SET. `List<KV<>>` could be 
a CONTAINER_TYPE, `Map<>` is not.
   
   <!--section:body-->
   I'm still confused about this. In most systems, Map is considered a 
container (e.g. in Java Map is a container type)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 90755)
    Time Spent: 4h 10m  (was: 4h)

> support data type MAP
> ---------------------
>
>                 Key: BEAM-2990
>                 URL: https://issues.apache.org/jira/browse/BEAM-2990
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>            Priority: Major
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> support Non-scalar types:
> MAP   Collection of keys mapped to values
> ARRAY         Ordered, contiguous collection that may contain duplicates



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to