[
https://issues.apache.org/jira/browse/BEAM-2990?focusedWorklogId=90897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90897
]
ASF GitHub Bot logged work on BEAM-2990:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/18 17:10
Start Date: 13/Apr/18 17:10
Worklog Time Spent: 10m
Work Description: XuMingmin commented on a change in pull request #5079:
[BEAM-2990] support MAP in SQL schema
URL: https://github.com/apache/beam/pull/5079#discussion_r181452879
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -208,6 +209,7 @@ public int hashCode() {
public static final Set<TypeName> STRING_TYPES = ImmutableSet.of(STRING);
public static final Set<TypeName> DATE_TYPES = ImmutableSet.of(DATETIME);
public static final Set<TypeName> CONTAINER_TYPES = ImmutableSet.of(ARRAY);
+ public static final Set<TypeName> MAP_TYPES = ImmutableSet.of(MAP);
Review comment:
In Java, container extends `Collection` and map extends `Map`, they're very
different IMO. If we merge them together I don't see any benefit as this is a
backend function and developers are using either
`TypeName.ARRAY.type().withComponentType()` or
`TypeName.MAP.type().withMapType`.
To make it clear, I would prefer to use the term **Collection** instead of
*Component* or *Contianer*. Any comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 90897)
Time Spent: 4h 40m (was: 4.5h)
> support data type MAP
> ---------------------
>
> Key: BEAM-2990
> URL: https://issues.apache.org/jira/browse/BEAM-2990
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> support Non-scalar types:
> MAP Collection of keys mapped to values
> ARRAY Ordered, contiguous collection that may contain duplicates
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
