[
https://issues.apache.org/jira/browse/BEAM-3997?focusedWorklogId=92472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92472
]
ASF GitHub Bot logged work on BEAM-3997:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 09:25
Start Date: 19/Apr/18 09:25
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5097:
[BEAM-3997] HCatalog integration test
URL: https://github.com/apache/beam/pull/5097#discussion_r182655049
##########
File path:
sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOTestPipelineOptions.java
##########
@@ -133,4 +133,29 @@
String getMongoDBDatabaseName();
void setMongoDBDatabaseName(String name);
+
+ /* HCatalog */
+ @Description("HCatalog metastore host (hostname/ip address)")
+ @Default.String("hcatalog-metastore")
+ String getHCatalogMetastoreHostName();
Review comment:
The use of a generic `IOTestPipelineOptions` should be discouraged, in
particular if we are creating a new IT. We should start doing it properly now.
So can you please move this into a specific `HCatalogIOITOptions` contained in
the HCatalog module.
@lgajowy I know this can seem different from what we have done before for
ITs, but this was an error that has to be corrected. Do we have a strong
technical reason to not do this properly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 92472)
Time Spent: 1h 20m (was: 1h 10m)
> implement HCatalog integration test
> -----------------------------------
>
> Key: BEAM-3997
> URL: https://issues.apache.org/jira/browse/BEAM-3997
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Dariusz Aniszewski
> Assignee: Jason Kuster
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
