[
https://issues.apache.org/jira/browse/BEAM-3997?focusedWorklogId=92476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92476
]
ASF GitHub Bot logged work on BEAM-3997:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 09:25
Start Date: 19/Apr/18 09:25
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5097:
[BEAM-3997] HCatalog integration test
URL: https://github.com/apache/beam/pull/5097#discussion_r182664710
##########
File path:
sdks/java/io/hcatalog/src/test/java/org/apache/beam/sdk/io/hcatalog/HiveDatabaseTestHelper.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.beam.sdk.io.hcatalog;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.SQLException;
+import java.sql.Statement;
+import org.apache.beam.sdk.io.common.DatabaseTestHelper;
+
+/**
+ * Helper for creating connection and test tables on hive database via JDBC
driver.
+ */
+
+public class HiveDatabaseTestHelper {
+ private static Connection con;
+ private static Statement stmt;
+
+ HiveDatabaseTestHelper(String hiveHost,
+ Integer hivePort,
+ String hiveDatabase) throws SQLException {
+ String driverName = "org.apache.hadoop.hive.jdbc.HiveDriver";
Review comment:
Since this is not an argument, maybe make it a constant and put in class
scope (`private static final ...`) or if not also inline (remove the extra var
and put the string in the `.forName` call).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 92476)
Time Spent: 1h 50m (was: 1h 40m)
> implement HCatalog integration test
> -----------------------------------
>
> Key: BEAM-3997
> URL: https://issues.apache.org/jira/browse/BEAM-3997
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Dariusz Aniszewski
> Assignee: Jason Kuster
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
