[
https://issues.apache.org/jira/browse/BEAM-3997?focusedWorklogId=92548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92548
]
ASF GitHub Bot logged work on BEAM-3997:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 12:57
Start Date: 19/Apr/18 12:57
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #5097:
[BEAM-3997] HCatalog integration test
URL: https://github.com/apache/beam/pull/5097#discussion_r182735485
##########
File path:
sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOTestPipelineOptions.java
##########
@@ -133,4 +133,29 @@
String getMongoDBDatabaseName();
void setMongoDBDatabaseName(String name);
+
+ /* HCatalog */
+ @Description("HCatalog metastore host (hostname/ip address)")
+ @Default.String("hcatalog-metastore")
+ String getHCatalogMetastoreHostName();
Review comment:
I agree - this topic reappears from time to time so it's definitely a good
moment to deal with it especially because we plan to focus on improving
tests/framework now. However I think some options are generic by it's nature
(eg. "numberOfRecords"). How about leaving such in IOTestPipelineOptions and
move "test specific" to a another options interface (eg.
HCatalogPipelineOptions in hcatalog module's tests)?
I wouldn't touch other tests in this PR though - let's do this in separate
[JIRA](https://issues.apache.org/jira/browse/BEAM-4137) issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 92548)
Time Spent: 2.5h (was: 2h 20m)
> implement HCatalog integration test
> -----------------------------------
>
> Key: BEAM-3997
> URL: https://issues.apache.org/jira/browse/BEAM-3997
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Dariusz Aniszewski
> Assignee: Jason Kuster
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
