[ 
https://issues.apache.org/jira/browse/BEAM-3327?focusedWorklogId=92873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92873
 ]

ASF GitHub Bot logged work on BEAM-3327:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Apr/18 21:57
            Start Date: 19/Apr/18 21:57
    Worklog Time Spent: 10m 
      Work Description: jkff commented on a change in pull request #5189: 
[BEAM-3327] Basic Docker environment factory
URL: https://github.com/apache/beam/pull/5189#discussion_r182896330
 
 

 ##########
 File path: 
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/InProcessSdkHarness.java
 ##########
 @@ -98,8 +113,10 @@ public ManagedChannel forDescriptor(ApiServiceDescriptor 
apiServiceDescriptor) {
           return null;
         });
 
-    client = SdkHarnessClient.usingFnApiClient(clientPool.getSource().get(),
-        dataServer.getService());
+    // HACK: Worker ids cannot currently be set by harness. Everything uses 
the null id for now.
 
 Review comment:
   <!--new_thread; commit:1fd121da1417624b3b84f0300648251da64b9cb5; 
resolved:0-->
   Is there a JIRA about them being set by the harness?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 92873)
    Time Spent: 10h 40m  (was: 10.5h)

> Add abstractions to manage Environment Instance lifecycles.
> -----------------------------------------------------------
>
>                 Key: BEAM-3327
>                 URL: https://issues.apache.org/jira/browse/BEAM-3327
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-core
>            Reporter: Thomas Groh
>            Assignee: Ben Sidhom
>            Priority: Major
>              Labels: portability
>          Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> This permits remote stage execution for arbitrary environments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to