[
https://issues.apache.org/jira/browse/BEAM-3327?focusedWorklogId=92871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92871
]
ASF GitHub Bot logged work on BEAM-3327:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 21:57
Start Date: 19/Apr/18 21:57
Worklog Time Spent: 10m
Work Description: jkff commented on a change in pull request #5189:
[BEAM-3327] Basic Docker environment factory
URL: https://github.com/apache/beam/pull/5189#discussion_r182896324
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/ControlClientPool.java
##########
@@ -17,16 +17,12 @@
*/
package org.apache.beam.runners.fnexecution.control;
-import org.apache.beam.sdk.fn.function.ThrowingConsumer;
-import org.apache.beam.sdk.util.ThrowingSupplier;
-
/** Control client pool that exposes a source and sink of control clients. */
-public interface ControlClientPool<T extends InstructionRequestHandler> {
+public interface ControlClientPool {
/** Source of control clients. */
Review comment:
<!--new_thread; commit:1fd121da1417624b3b84f0300648251da64b9cb5;
resolved:0-->
Generally, why the higher-order functions here: why not have
ControlClientPool have a function for getting a client, and a function for
adding a client to the pool? That would match how other pool-like abstractions
typically work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 92871)
Time Spent: 10h 20m (was: 10h 10m)
> Add abstractions to manage Environment Instance lifecycles.
> -----------------------------------------------------------
>
> Key: BEAM-3327
> URL: https://issues.apache.org/jira/browse/BEAM-3327
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Ben Sidhom
> Priority: Major
> Labels: portability
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> This permits remote stage execution for arbitrary environments
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
