[
https://issues.apache.org/jira/browse/BEAM-4059?focusedWorklogId=93284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-93284
]
ASF GitHub Bot logged work on BEAM-4059:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/18 17:04
Start Date: 20/Apr/18 17:04
Worklog Time Spent: 10m
Work Description: swegner opened a new pull request #5193: [BEAM-4059]
Reduce number of ValidatesRunner tests and reorganize them for better
parallelization
URL: https://github.com/apache/beam/pull/5193
Dataflow ValidatesRunner test suite has gotten obscenely slow due to the
number of ValidatesRunner tests. There are currently over 250, and each one
takes at least 3 minutes to run on Dataflow. Many of them don't actually need
to be run on every worker, and this test converts them to `@NeedsRunner` tests
instead.
Gradle also parallelizes tests differently, parallelizing at the test class
level rather than per test case. As a result, the largest test class will be a
bottleneck for the overall execution. This PR splits up large
`@ValidatesRunner` test classes into scenario-based subclasses.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand:
- [ ] What the pull request does
- [ ] Why it does it
- [ ] How it does it
- [ ] Why this approach
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Run `./gradlew build` to make sure basic checks pass. A more thorough
check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 93284)
Time Spent: 40m (was: 0.5h)
> Make sure Dataflow ValidatesRunner tests pass in Gradle
> -------------------------------------------------------
>
> Key: BEAM-4059
> URL: https://issues.apache.org/jira/browse/BEAM-4059
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Pablo Estrada
> Assignee: Scott Wegner
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> See
> https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
