[
https://issues.apache.org/jira/browse/BEAM-4059?focusedWorklogId=93349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-93349
]
ASF GitHub Bot logged work on BEAM-4059:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/18 18:29
Start Date: 20/Apr/18 18:29
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5193: [BEAM-4059] Reduce number of ValidatesRunner tests and reorganize them
for better parallelization
URL: https://github.com/apache/beam/pull/5193#discussion_r183133945
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java
##########
@@ -184,13 +184,13 @@ public void testSimpleCombineWithContext() {
}
@Test
- @Category(ValidatesRunner.class)
+ @Category(NeedsRunner.class)
Review comment:
For Combine there's an argument to bring some of them back since this is
almost always implemented as a primitive, even though it is not one,
technically. I would favor a JIRA TODO for factoring Combine into two suites -
one for the composite's various configs but one that is focused on testing a
runner's basic primitive implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 93349)
Time Spent: 2h (was: 1h 50m)
> Make sure Dataflow ValidatesRunner tests pass in Gradle
> -------------------------------------------------------
>
> Key: BEAM-4059
> URL: https://issues.apache.org/jira/browse/BEAM-4059
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Pablo Estrada
> Assignee: Scott Wegner
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> See
> https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
