[
https://issues.apache.org/jira/browse/BEAM-4059?focusedWorklogId=93345&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-93345
]
ASF GitHub Bot logged work on BEAM-4059:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/18 18:29
Start Date: 20/Apr/18 18:29
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5193: [BEAM-4059] Reduce number of ValidatesRunner tests and reorganize them
for better parallelization
URL: https://github.com/apache/beam/pull/5193#discussion_r183134308
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CreateTest.java
##########
@@ -224,7 +224,7 @@ public UnserializableRecord decode(
}
@Test
- @Category(ValidatesRunner.class)
+ @Category(NeedsRunner.class)
Review comment:
How many runners are currently overriding Create as a primitive? If they
aren't, then done! If they are, then (and this is a new thought that I thought
of after my prior comments) another place for the tests to move is into ITs for
just that runner, via some organization of modules. This is after-this-PR
suggestion. I'm OK with this as-is unless runners are all turning it back into
a primitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 93345)
Time Spent: 1.5h (was: 1h 20m)
> Make sure Dataflow ValidatesRunner tests pass in Gradle
> -------------------------------------------------------
>
> Key: BEAM-4059
> URL: https://issues.apache.org/jira/browse/BEAM-4059
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Pablo Estrada
> Assignee: Scott Wegner
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> See
> https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
