[
https://issues.apache.org/jira/browse/BEAM-4044?focusedWorklogId=98530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98530
]
ASF GitHub Bot logged work on BEAM-4044:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 18:14
Start Date: 04/May/18 18:14
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5224: [BEAM-4044] [SQL] Add tables via TableStore in Schema, execute DDL in
Calcite model
URL: https://github.com/apache/beam/pull/5224#discussion_r186172960
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java
##########
@@ -369,8 +370,8 @@ private Row buildNullRow(BeamRelNode relNode) {
private PCollection<Row> joinAsLookup(
BeamRelNode leftRelNode,
BeamRelNode rightRelNode,
- PCollectionTuple inputPCollections) {
- PCollection<Row> factStream =
inputPCollections.apply(leftRelNode.toPTransform());
+ PInput inputPCollections) {
+ PCollection<Row> factStream =
inputPCollections.getPipeline().apply(leftRelNode.toPTransform());
Review comment:
`getPipeline().apply()` is probably not what you want here, either. It is
actually a bad method - it is the same as `getPipeline().begin().apply()` so it
always starts a new initial pipeline segment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98530)
Time Spent: 11h 50m (was: 11h 40m)
> Take advantage of Calcite DDL
> -----------------------------
>
> Key: BEAM-4044
> URL: https://issues.apache.org/jira/browse/BEAM-4044
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> In Calcite 1.15 support for abstract DDL moved into calcite core. We should
> take advantage of that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
