[
https://issues.apache.org/jira/browse/BEAM-4044?focusedWorklogId=98533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98533
]
ASF GitHub Bot logged work on BEAM-4044:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 18:14
Start Date: 04/May/18 18:14
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5224: [BEAM-4044] [SQL] Add tables via TableStore in Schema, execute DDL in
Calcite model
URL: https://github.com/apache/beam/pull/5224#discussion_r186171758
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/parser/SqlDropObject.java
##########
@@ -51,8 +59,39 @@
name.unparse(writer, leftPrec, rightPrec);
}
- public String getNameSimple() {
- return name.getSimple().toLowerCase();
+ public void execute(CalcitePrepare.Context context) {
+ final List<String> path = context.getDefaultSchemaPath();
+ CalciteSchema schema = context.getRootSchema();
+ for (String p : path) {
+ schema = schema.getSubSchema(p, true);
+ }
+ final boolean existed;
+ switch (getKind()) {
+ case DROP_TABLE:
+ case DROP_MATERIALIZED_VIEW:
Review comment:
Interesting question for the future. For pure SQL REPL use, we probably
would want something to name queries for reuse. Does calcite manage these for
us, and only delegates materialized views?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98533)
Time Spent: 12h 20m (was: 12h 10m)
> Take advantage of Calcite DDL
> -----------------------------
>
> Key: BEAM-4044
> URL: https://issues.apache.org/jira/browse/BEAM-4044
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> In Calcite 1.15 support for abstract DDL moved into calcite core. We should
> take advantage of that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
