[
https://issues.apache.org/jira/browse/BEAM-4044?focusedWorklogId=98537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98537
]
ASF GitHub Bot logged work on BEAM-4044:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 18:14
Start Date: 04/May/18 18:14
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5224: [BEAM-4044] [SQL] Add tables via TableStore in Schema, execute DDL in
Calcite model
URL: https://github.com/apache/beam/pull/5224#discussion_r186172690
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java
##########
@@ -133,9 +133,10 @@ public Join copy(
.setCoder(CalciteUtils.toBeamSchema(getRowType()).getRowCoder());
}
- PCollection<Row> leftRows = inputPCollections.apply("left",
leftRelNode.toPTransform());
+ PCollection<Row> leftRows =
+ inputPCollections.getPipeline().apply("left",
leftRelNode.toPTransform());
PCollection<Row> rightRows =
- inputPCollections.apply("right", rightRelNode.toPTransform());
+ inputPCollections.getPipeline().apply("right",
rightRelNode.toPTransform());
Review comment:
Agree. Does this actually work? If so, is there a different data path
whereby the left and right collections are passed as input? This invocation
will not register them as inputs to the transform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98537)
Time Spent: 12.5h (was: 12h 20m)
> Take advantage of Calcite DDL
> -----------------------------
>
> Key: BEAM-4044
> URL: https://issues.apache.org/jira/browse/BEAM-4044
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
> In Calcite 1.15 support for abstract DDL moved into calcite core. We should
> take advantage of that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
