[
https://issues.apache.org/jira/browse/BEAM-4073?focusedWorklogId=98624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98624
]
ASF GitHub Bot logged work on BEAM-4073:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 23:12
Start Date: 04/May/18 23:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5270:
[BEAM-4073] Migrate the `portable` subpackage to use Portable representations
URL: https://github.com/apache/beam/pull/5270#discussion_r186239394
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/PipelineExecutor.java
##########
@@ -17,30 +17,30 @@
*/
package org.apache.beam.runners.direct.portable;
+import
org.apache.beam.runners.core.construction.graph.PipelineNode.PCollectionNode;
+import
org.apache.beam.runners.core.construction.graph.PipelineNode.PTransformNode;
import org.apache.beam.runners.direct.ExecutableGraph;
import org.apache.beam.sdk.Pipeline;
import org.apache.beam.sdk.PipelineResult.State;
-import org.apache.beam.sdk.runners.AppliedPTransform;
import org.apache.beam.sdk.transforms.PTransform;
-import org.apache.beam.sdk.values.PCollection;
import org.joda.time.Duration;
/**
- * An executor that schedules and executes {@link AppliedPTransform
AppliedPTransforms} for both
- * source and intermediate {@link PTransform PTransforms}.
+ * An executor that schedules and executes {@link PTransformNode
AppliedPTransforms} for both source
+ * and intermediate {@link PTransform PTransforms}.
*/
interface PipelineExecutor {
/**
* Starts this executor on the provided graph. The {@link
RootProviderRegistry} will be used to
* create initial inputs for the provide {@link ExecutableGraph graph}.
*/
void start(
- ExecutableGraph<AppliedPTransform<?, ?, ?>, PCollection<?>> graph,
+ ExecutableGraph<PTransformNode, PCollectionNode> graph,
RootProviderRegistry rootProviderRegistry);
/**
* Blocks until the job being executed enters a terminal state. A job is
completed after all root
- * {@link AppliedPTransform AppliedPTransforms} have completed, and all
{@link CommittedBundle
+ * {@link PTransformNode AppliedPTransforms} have completed, and all {@link
CommittedBundle
Review comment:
nit: AppliedPTransforms?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98624)
Time Spent: 2.5h (was: 2h 20m)
> The DirectRunner should interact with a Pipeline via an abstraction of the
> Graph rather than SDK types
> ------------------------------------------------------------------------------------------------------
>
> Key: BEAM-4073
> URL: https://issues.apache.org/jira/browse/BEAM-4073
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
