[
https://issues.apache.org/jira/browse/BEAM-4073?focusedWorklogId=98629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98629
]
ASF GitHub Bot logged work on BEAM-4073:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 23:13
Start Date: 04/May/18 23:13
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5270:
[BEAM-4073] Migrate the `portable` subpackage to use Portable representations
URL: https://github.com/apache/beam/pull/5270#discussion_r186239807
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/WindowEvaluatorFactory.java
##########
@@ -43,41 +42,32 @@
@Override
public <InputT> TransformEvaluator<InputT> forApplication(
- AppliedPTransform<?, ?, ?> application,
+ PTransformNode application,
@Nullable CommittedBundle<?> inputBundle
)
throws Exception {
- return createTransformEvaluator((AppliedPTransform) application);
+ return createTransformEvaluator((PTransformNode) application);
Review comment:
I don't think you need this case anymore since you don't have any wildcard
types anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98629)
Time Spent: 3h (was: 2h 50m)
> The DirectRunner should interact with a Pipeline via an abstraction of the
> Graph rather than SDK types
> ------------------------------------------------------------------------------------------------------
>
> Key: BEAM-4073
> URL: https://issues.apache.org/jira/browse/BEAM-4073
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
