[
https://issues.apache.org/jira/browse/BEAM-4290?focusedWorklogId=106953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106953
]
ASF GitHub Bot logged work on BEAM-4290:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/18 00:04
Start Date: 30/May/18 00:04
Worklog Time Spent: 10m
Work Description: axelmagn commented on a change in pull request #5489:
[BEAM-4290] proto changes to support artifact_staging_id
URL: https://github.com/apache/beam/pull/5489#discussion_r191610323
##########
File path: model/job-management/src/main/proto/beam_artifact_api.proto
##########
@@ -102,13 +99,19 @@ message ArtifactChunk {
bytes data = 1;
}
+message PutArtifactMetadata {
+ // (Required) An identifier for artifact staging session.
+ string artifact_staging_id = 1;
Review comment:
Okay, so then `artifact_staging_id` is in fact more than an identifier. At
the very least we should reflect that in the comments. I guess I can understand
that staging and retrieval will require different metadata, but in that case I
think we need better, more clear names.
I think that `artifact_staging_id -> artifact_staging_token` (because it's
for staging) and `staging_token -> artifact_retrieval_token` (because it's for
retrieval) correctly communicates how they are intended to be used, but it will
be confusing for current developers who will hear `artifact_staging_token` and
think of the thing that is now called `artifact_retrieval_token`. An
alternative would be `artifact_staging_id -> staging_session_token`, making the
distinction that one token is for the staging session, while `staging_token` is
the output (which could still have a better name, but maybe we don't fight that
battle here).
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106953)
Time Spent: 1.5h (was: 1h 20m)
> ArtifactStagingService that stages to a distributed filesystem
> --------------------------------------------------------------
>
> Key: BEAM-4290
> URL: https://issues.apache.org/jira/browse/BEAM-4290
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Using the job's staging directory from PipelineOptions.
> Physical layout on the distributed filesystem is TBD but it should allow for
> arbitrary filenames and ideally for eventually avoiding uploading artifacts
> that are already there.
> Handling credentials is TBD.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
