[
https://issues.apache.org/jira/browse/BEAM-4290?focusedWorklogId=107331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107331
]
ASF GitHub Bot logged work on BEAM-4290:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/18 19:11
Start Date: 30/May/18 19:11
Worklog Time Spent: 10m
Work Description: axelmagn commented on a change in pull request #5489:
[BEAM-4290] proto changes to support artifact_staging_id
URL: https://github.com/apache/beam/pull/5489#discussion_r191888360
##########
File path: model/job-management/src/main/proto/beam_artifact_api.proto
##########
@@ -102,13 +99,19 @@ message ArtifactChunk {
bytes data = 1;
}
+message PutArtifactMetadata {
+ // (Required) An identifier for artifact staging session.
+ string artifact_staging_id = 1;
Review comment:
The discussion document alludes to the following items to be specified by
the job service and passed to the staging service:
- Base directory to put artifacts in.
- TTL for the artifacts.
- Authentication to submit artifacts.
- Credentials to store artifacts in distributed file system.
Of these, how much is going to fit into the `artifact_staging_id`? Since
this is already a metadata proto, why are we packing data into a string to be
parsed later? Is there a particular parser for it that we already have an
implementation for? If so, we need to document it as such. Otherwise I'd
recommend that any metadata contained within the `artifact_staging_id` should
be made explicit as fields in `PutArtifactMetadata`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107331)
Time Spent: 2h 20m (was: 2h 10m)
> ArtifactStagingService that stages to a distributed filesystem
> --------------------------------------------------------------
>
> Key: BEAM-4290
> URL: https://issues.apache.org/jira/browse/BEAM-4290
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Using the job's staging directory from PipelineOptions.
> Physical layout on the distributed filesystem is TBD but it should allow for
> arbitrary filenames and ideally for eventually avoiding uploading artifacts
> that are already there.
> Handling credentials is TBD.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
